You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The mypy CI job remains intact, but it will never fail or block CI. Eventually we should gate merges if coverage dips below 100%, but we aren't there yet.
• Remove mypy type coverage publication to codecov.io from CI
• Update job names to be more descriptive
• Remove lxml dependency from mypy environment
• Keep mypy checks running but non-blocking
Changes walkthrough 📝
Relevant files
Configuration changes
ci-python.yml
Remove codecov integration from CI workflow
.github/workflows/ci-python.yml
• Updated job step names for clarity ("Generate docs", "Run type checking") • Removed codecov publication commands and bash script execution • Simplified mypy job to only run type checking without coverage reporting
The mypy job now uses || true which will always succeed even if type checking fails. This could mask legitimate type checking issues and defeats the purpose of running mypy in CI.
The || true command prevents CI from failing when type checking finds issues, which defeats the purpose of running type checks in CI. Remove || true to ensure type checking failures are properly reported and cause the CI to fail.
- name: Run type checking
run: |
- tox -c py/tox.ini || true+ tox -c py/tox.ini
env:
TOXENV: mypy
Apply / Chat
Suggestion importance[1-10]: 9
__
Why: The suggestion correctly identifies that || true suppresses errors from the type checker, which undermines the purpose of having a type-checking step in the CI pipeline. Removing it ensures that type errors will cause the build to fail, enforcing code quality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
selenium-ci
added
C-py
User description
💥 What does this PR do?
This PR removes publication of mypy type coverage during CI runs (introduced in #9523). The coverage stats were previously published to codecov.io (https://app.codecov.io/gh/SeleniumHQ/selenium/), but they haven't been updated in over 5 months. AFAIK nobody is looking at them.
The mypy CI job remains intact, but it will never fail or block CI. Eventually we should gate merges if coverage dips below 100%, but we aren't there yet.
mypy type coverage is being tracked in #15697
🔄 Types of changes
PR Type
Other
Description
• Remove mypy type coverage publication to codecov.io from CI
• Update job names to be more descriptive
• Remove lxml dependency from mypy environment
• Keep mypy checks running but non-blocking
Changes walkthrough 📝
ci-python.yml
Remove codecov integration from CI workflow.github/workflows/ci-python.yml
• Updated job step names for clarity ("Generate docs", "Run type
checking")
• Removed codecov publication commands and bash script
execution
• Simplified mypy job to only run type checking without
coverage reporting
tox.ini
Remove lxml dependency from mypy environmentpy/tox.ini
• Removed lxml dependency from mypy test environment
• Cleaned up
dependencies list for type checking