PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

meth = getattr(self.input_source, action)
meth(letter)

PR Code Suggestions ✨

Latest suggestions up to 82a4897

 # Determine the correct source type string based on the input object
-if isinstance(source, KeyInput):
+if hasattr(source, 'type'):
+    source_type = source.type
+elif isinstance(source, KeyInput):
     source_type = KEY
 elif isinstance(source, PointerInput):
     source_type = POINTER
 elif isinstance(source, WheelInput):
     source_type = WHEEL
 else:
     source_type = KEY  # fallback
     
 super().__init__(source_type)

Previous suggestions

-        super().__init__(KEY)
+        super().__init__(self.input_source)

 def __init__(self, source: KeyInput | PointerInput | WheelInput | None = None) -> None:
     if source is None:
         source = KeyInput(KEY)
     self.input_source = source
-    super().__init__(KEY)
+    super().__init__(self.input_source)

ran these two commands -
pytest bazel-selenium/py/test/selenium/webdriver/common/interactions_with_device_tests.py
pytest bazel-selenium/py/test/selenium/webdriver/common/interactions_tests.py

are these the correct tests to run for this file ? @navin772 , can you kindly please guide. thanks.

This is the test command - pytest py/test/selenium/webdriver/common/w3c_interaction_tests.py. You can also run the 2 test files you mentioned.

ran this - pytest bazel-selenium/py/test/selenium/webdriver/common/w3c_interaction_tests.py
got these errors
bazel-selenium/py/test/selenium/webdriver/common/w3c_interaction_tests.py::test_touch_pointer_properties FAILED
E AssertionError: assert 9 == 7
E + where 9 = len([{'altKey': False, 'altitudeAngle': 1.1827416313714896, 'azimuthAngle': 5.932221251670766, 'button': 0, ...}, {'altKey': False, 'altitudeAngle': 1.1827416313714896, 'azimuthAngle': 5.932221251670766, 'button': 0, ...}, {'altKey': False, 'altitudeAngle': 1.1827416313714896, 'azimuthAngle': 5.932221251670766, 'button': 0, ...}, {'altKey': False, 'altitudeAngle': 0.4818905427524743, 'azimuthAngle': 1.7518731617179564, 'button': -1, ...}, {'altKey': False, 'altitudeAngle': 1.5707963267948966, 'azimuthAngle': 0, 'button': -1, ...}, {'altKey': False, 'altitudeAngle': 1.5707963267948966, 'azimuthAngle': 0, 'button': -1, ...}, ...])

py/test/selenium/webdriver/common/w3c_interaction_tests.py:251: AssertionError

@navin772 -- i don't think it is related. is it?

please run the formatter on your branch.

@cgoldberg if i don't change the source var, the w3c test throws error
FAILED bazel-selenium/py/test/selenium/webdriver/common/w3c_interaction_tests.py::test_sending_keys_to_active_element_with_modifier - AttributeError: 'str' object has no attribute 'create_key_down'
FAILED bazel-selenium/py/test/selenium/webdriver/common/w3c_interaction_tests.py::test_can_create_pause_action_on_keyboard - AttributeError: 'str' object has no attribute 'create_pause'

-using another variable to call on actual object then str.

--i changed the key action method, thank you for helping.

@cgoldberg
if i go back to original file where we don't separate source type and input source, mypy errors come as follows-
selenium/webdriver/common/actions/key_actions.py:31: error: Incompatible types in assignment (expression has type "KeyInput | PointerInput | WheelInput", variable has type "str") [assignment]
selenium/webdriver/common/actions/key_actions.py:43: error: Argument 1 to "init" of "Interaction" has incompatible type "KeyInput | PointerInput | WheelInput"; expected "str" [arg-type]

w3c tests pass.

with separating these vars, w3c tests passes and mypy errors get fixed.

i am renaming the variables-
Interaction class - defines source as str
but for some we need actual object -like method create key down

looked at the pointer, wheel and key input files.

mypy errors arent there now.
ran pytest for w3c and both interactions
ran format
ran ruff

please let me know if there is anything else? i am trying to understand. thanks Corey.

if i go back to original file where we don't separate source type and input source, mypy errors come as follows

OK, I understand now.
I just removed the comments in your branch.. this looks good now.

Thank you @cgoldberg .