Skip to content

[py] allow logging diagnose in safari driver #14606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harsha509 merged 3 commits into from
Oct 17, 2024
Merged

[py] allow logging diagnose in safari driver #14606

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e322be3
[py] allow logging diagnose in safari driver
Delta456 Oct 16, 2024
10bb227
Merge branch 'trunk' into safari_logging
Delta456 Oct 16, 2024
531f0c3
Merge branch 'trunk' into safari_logging
Delta456 Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions py/selenium/webdriver/safari/service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ class Service(service.Service):
:param port: Port for the service to run on, defaults to 0 where the operating system will decide.
:param service_args: (Optional) List of args to be passed to the subprocess when launching the executable.
:param env: (Optional) Mapping of environment variables for the new process, defaults to `os.environ`.
:param enable_logging: (Optional) Enable logging of the service. Logs can be located at `~/Library/Logs/com.apple.WebDriver/`
"""

def __init__(
Expand All @@ -37,12 +38,16 @@ def __init__(
service_args: typing.Optional[typing.List[str]] = None,
env: typing.Optional[typing.Mapping[str, str]] = None,
reuse_service=False,
enable_logging: bool = False,
driver_path_env_key: str = None,
**kwargs,
) -> None:
self.service_args = service_args or []
driver_path_env_key = driver_path_env_key or "SE_SAFARIDRIVER"

if enable_logging:
self.service_args.append("--diagnose")

self.reuse_service = reuse_service
super().__init__(
executable_path=executable_path,
Expand Down