[py] Remote connection throws resp status code when data is empty#14601
[py] Remote connection throws resp status code when data is empty#14601
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
CI Failure Feedback 🧐(Checks updated until commit bc3220a)
|
e1243bd to
890f130
Compare
Signed-off-by: Viet Nguyen Duc <[email protected]>
890f130 to
bc3220a
Compare
…leniumHQ#14601) Signed-off-by: Viet Nguyen Duc <[email protected]>
…leniumHQ#14601) Signed-off-by: Viet Nguyen Duc <[email protected]>
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
By a chance establish remote connection to Grid that requires basic auth. The exception without Message, e.g
Adding explicit message for status 401
Also, return the code status in case the response data is empty, so we have at least a status code to guess the issue instead of an empty Message.
After fixed:
Types of changes
Checklist
PR Type
bug_fix, enhancement
Description
Changes walkthrough 📝
remote_connection.py
Improve error handling for remote connection responsespy/selenium/webdriver/remote/remote_connection.py