[dotnet] Fix protocol cdp version for remote webdriver#13507
Merged
Conversation
Member
Author
|
We also can consider a case when user specified protocol version, then we should not honor se:cdpVersion capability. |
Member
|
Oh, I really don't think we should go down the rabbit hole of letting users pick the version. This all goes away whenever we start implementing BiDi. 😄 |
Member
Author
|
It is the regression issue, just supporting things that has been working. I didn't verified this fix, will be able to do on Monday (01/29). |
Member
Author
|
Perfecto! Downloaded artifacts from EngFlow and verified this fix. Works good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Regression issue, it fixes determination of cdp version, returned back to the remote webdriver in capabilities.
Motivation and Context
Fixes #13502
Types of changes
Checklist