[java] fix bug for appium subclass that sets neither log file nor out… #12696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diemol
approved these changes
Sep 6, 2023
titusfortner
force-pushed
the
appium_service
branch
from
2e6d6ad to
a91302e
Compare
valfirst
approved these changes
Sep 6, 2023
valfirst
reviewed
Sep 6, 2023
titusfortner
force-pushed
the
appium_service
branch
from
a91302e to
4ef79bd
Compare
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## trunk #12696 +/- ##
==========================================
- Coverage 57.02% 56.99% -0.04%
==========================================
Files 86 86
Lines 5322 5325 +3
Branches 192 192
==========================================
Hits 3035 3035
- Misses 2095 2098 +3
Partials 192 192
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…put stream
Description
Allow subclasses not to set either log file or log output
Motivation and Context
Fix appium/java-client#2004