Skip to content

[py] Add creation flag for windows in selenium_manager#12435

Merged
symonk merged 3 commits intoSeleniumHQ:trunkfrom
SenZmaKi:trunk
Jul 29, 2023
Merged

[py] Add creation flag for windows in selenium_manager#12435
symonk merged 3 commits intoSeleniumHQ:trunkfrom
SenZmaKi:trunk

Conversation

@SenZmaKi
Copy link
Copy Markdown
Contributor

@SenZmaKi SenZmaKi commented Jul 28, 2023 •
edited
Loading

Addresses Issue: #12427

The call to subprocess.run is made without the flag creationflags=CREATE_NO_WINDOW for windows platform which results in a brief console window popping up if the script is built into an executable that doesn't already have a console window e.g for a GUI app. The following pull request looks to address the aforementioned issue.

Bug

completed_proc = subprocess.run(args, stdout=subprocess.PIPE, stderr=subprocess.PIPE, check=False)

Fix

if sys.platform == "win32":
     completed_proc = subprocess.run(args, stdout=subprocess.PIPE, stderr=subprocess.PIPE, creationflags=subprocess.CREATE_NO_WINDOW)
else: 
     completed_proc = subprocess.run(args, stdout=subprocess.PIPE, stderr=subprocess.PIPE)

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jul 28, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@SenZmaKi SenZmaKi changed the title [py] Add creation flag for windows in selenium_manager (#12427) [py] Add creation flag for windows in selenium_manager Jul 28, 2023
symonk
symonk reviewed Jul 29, 2023
View reviewed changes
Comment thread py/selenium/webdriver/common/selenium_manager.py
@symonk
Copy link
Copy Markdown
Member

symonk commented Jul 29, 2023

closes #12427

@symonk symonk added the C-py Python Bindings label Jul 29, 2023
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 29, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (0c48804) 57.40% compared to head (11f69e7) 57.41%.
Report is 2 commits behind head on trunk.

❗ Current head 11f69e7 differs from pull request most recent head 61f6169. Consider uploading reports for the commit 61f6169 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@            Coverage Diff             @@
##            trunk   #12435      +/-   ##
==========================================
+ Coverage   57.40%   57.41%   +0.01%     
==========================================
  Files          86       86              
  Lines        5369     5371       +2     
  Branches      206      206              
==========================================
+ Hits         3082     3084       +2     
  Misses       2081     2081              
  Partials      206      206
Files Changed Coverage Δ
py/selenium/webdriver/edge/webdriver.py 82.35% <ø> (ø)
py/selenium/webdriver/remote/webdriver.py 40.13% <ø> (ø)
py/selenium/webdriver/common/selenium_manager.py 57.74% <100.00%> (+1.22%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@symonk symonk merged commit f41bc81 into SeleniumHQ:trunk Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@symonk symonk symonk approved these changes

Assignees

No one assigned

Labels

C-py Python Bindings

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SenZmaKi @CLAassistant @symonk @codecov-commenter