Skip to content

[rust] Return complete safari and safaritp browser path#12434

Merged
bonigarcia merged 2 commits intotrunkfrom
se_mgr_safari_path
Jul 31, 2023
Merged

[rust] Return complete safari and safaritp browser path#12434
bonigarcia merged 2 commits intotrunkfrom
se_mgr_safari_path

Conversation

@bonigarcia
Copy link
Copy Markdown
Member

@bonigarcia bonigarcia commented Jul 27, 2023

Description

This PR returns the full path of the Safari and Safari TP browser binary. For instance:

boni@Bonis-iMac rust % cargo run -- --browser safari --debug --browser-version stable
    Finished dev [unoptimized + debuginfo] target(s) in 0.32s
     Running `target/debug/selenium-manager --browser safari --debug --browser-version stable`
DEBUG	safari detected at /Applications/Safari.app
DEBUG	Using shell command to find out safari version
DEBUG	Running command: /usr/libexec/PlistBuddy -c "print :CFBundleShortVersionString" /Applications/Safari.app/Contents/Info.plist
DEBUG	Output: "14.0.1"
DEBUG	Required driver: safaridriver (local)
INFO	Driver path: /usr/bin/safaridriver
INFO	Browser path: /Applications/Safari.app/Contents/MacOS/Safari

Motivation and Context

This PR is part of the new features of Selenium Manager to discover the browser path. Ideally, this is part of the Selenium 4.11 release.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bonigarcia bonigarcia added the C-rust Rust code is mostly Selenium Manager label Jul 27, 2023
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (60a054b) 57.40% compared to head (86adc29) 57.40%.
Report is 5 commits behind head on trunk.

❗ Current head 86adc29 differs from pull request most recent head 8b4c265. Consider uploading reports for the commit 8b4c265 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@           Coverage Diff           @@
##            trunk   #12434   +/-   ##
=======================================
  Coverage   57.40%   57.40%           
=======================================
  Files          86       86           
  Lines        5369     5369           
  Branches      206      206           
=======================================
  Hits         3082     3082           
  Misses       2081     2081           
  Partials      206      206

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bonigarcia bonigarcia merged commit 3926580 into trunk Jul 31, 2023
@bonigarcia bonigarcia deleted the se_mgr_safari_path branch July 31, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diemol diemol diemol approved these changes

Assignees

No one assigned

Labels

C-rust Rust code is mostly Selenium Manager

Projects

Selenium Manager
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bonigarcia @codecov-commenter @diemol