Conversation
|
not 100% the best approach to rolling this out, don't want to shock users using 3.7 without ample notice. But this is a start on the changes required |
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## trunk #12400 +/- ##
=======================================
Coverage 57.01% 57.02%
=======================================
Files 86 86
Lines 5335 5322 -13
Branches 198 192 -6
=======================================
- Hits 3042 3035 -7
Misses 2095 2095
+ Partials 198 192 -6
☔ View full report in Codecov by Sentry. |
|
Do we have a sense of how many folk are on 3.7? I know its either EOL or about to be EOL |
|
Eol was end of June. |
|
The syntax changes in 3.7->3.8 is partly to blame. I'm ok with dropping it fully since it's past EOL |
|
In general this looks good. There are a number of conflicts |
|
Most of the changes are style related but it's good to use the more modern type annotations. This should be good to go once conflicts have been addressed. |
|
Looping back to this now, however i've some conflicts to resolve still, will squash as a single commit when ironed out |
Dropping support for
python3.7. This encompasses:closes #12399