[rust] Change default TTL_drivers from 86400s (1 day) to 3600s (1 hour)#12394
Merged
[rust] Change default TTL_drivers from 86400s (1 day) to 3600s (1 hour)#12394
Conversation
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## trunk #12394 +/- ##
=======================================
Coverage 57.28% 57.28%
=======================================
Files 86 86
Lines 5333 5333
Branches 193 193
=======================================
Hits 3055 3055
Misses 2085 2085
Partials 193 193
☔ View full report in Codecov by Sentry. |
titusfortner
approved these changes
Jul 21, 2023
diemol
approved these changes
Jul 21, 2023
This was referenced Aug 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the default
TTL_driversfrom 86400 seconds (i.e., 1 day) to 3600 seconds (i.e., 1 hour).Motivation and Context
The recent advent of the CfT endpoints has revealed that the rate of change of the recommended chromedriver versions changes more quickly than it used to. To avoid problems related to the cached resolved chromedriver versions, I recommend lowering the default value to
TTL_drivers.I propose to use 1 hour for this value.Also, I do not recommend disabling this TLL totally (it would be
TTL_driversto 0), but doing that way, for a test suite, there will be a network request to discover the chromedriver, each time aChromeDriverobject is created. As a result, the overall performance would be worse. I believe 1 hour is a good balance between performance and update.Types of changes
Checklist