[py] added type checks in setter methods of different browser options#12328
Merged
AutomatedTester merged 5 commits intoSeleniumHQ:trunkfrom Jul 26, 2023
Merged
[py] added type checks in setter methods of different browser options#12328AutomatedTester merged 5 commits intoSeleniumHQ:trunkfrom
setter methods of different browser options#12328AutomatedTester merged 5 commits intoSeleniumHQ:trunkfrom
Conversation
AutomatedTester
approved these changes
Jul 24, 2023
moritzj29
added a commit
to moritzj29/finance-dl
that referenced
this pull request
Nov 5, 2023
…is used (due to SeleniumHQ/selenium#12328 an empty `CHROMEDRIVER_CHROME_BINARY` is no longer allowed)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Added type checks in
settermethods of different browser options.Motivation and Context
The type check was not being done before setting the values of some browser options (e.g
binary_location) in setter methods of different browsers. I have added these validations insettermethods of below options.chromium/options.pyfirefox/options.pysafari/options.pywpewebkit/options.pysafari/services.pyTypes of changes
Checklist