[py] Moved all PrintOptions class attributes to custom descriptor class.#12297
Merged
AutomatedTester merged 3 commits intoSeleniumHQ:trunkfrom Jul 12, 2023
Merged
Conversation
AutomatedTester
approved these changes
Jul 4, 2023
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## trunk #12297 +/- ##
==========================================
- Coverage 56.92% 55.88% -1.04%
==========================================
Files 86 86
Lines 5423 5409 -14
Branches 193 193
==========================================
- Hits 3087 3023 -64
- Misses 2143 2193 +50
Partials 193 193
☔ View full report in Codecov by Sentry. |
Member
|
Linting job has failed please look |
Contributor
Author
Fixed. Now it should be fine. |
AutomatedTester
approved these changes
Jul 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Moved all page attributes in
PrintOptionsclass to custom descriptor class.Motivation and Context
properties.Types of changes
Checklist