[dotnet] Make WebDriver.csproj file more friendly with native pack command#12235
Merged
diemol merged 3 commits intoSeleniumHQ:trunkfrom Jun 27, 2023
nvborisenko:csproj-pack
Merged
[dotnet] Make WebDriver.csproj file more friendly with native pack command#12235diemol merged 3 commits intoSeleniumHQ:trunkfrom nvborisenko:csproj-pack
diemol merged 3 commits intoSeleniumHQ:trunkfrom
nvborisenko:csproj-pack
Conversation
Member
Author
|
Build is failing, but the changes are not related to it and should not break build process. Seems it was failing before, or tools were upgraded recently. I see it is failing because nuget tool cannot find If we cannot fix it quickly, then I can propose to turn off creation of symbols: https://github.com/SeleniumHQ/selenium/blob/a04a22f4490da1b9576f251a5f16fa34e8898645/dotnet/src/support/BUILD.bazel#LL129C31-L129C31. And return it back after @shs96c refactors the whole process of ci for .net. |
shs96c
added a commit
that referenced
this pull request
Jun 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Now I am able to create local nuget package with
dotnet packcommand.Motivation and Context
This is one step further to be more friendly for .net devs.
Types of changes
Checklist