[py] mapped all error codes in errorhandler.py to corresponding exception object.#12190
Merged
diemol merged 2 commits intoSeleniumHQ:trunkfrom Jun 12, 2023
Merged
[py] mapped all error codes in errorhandler.py to corresponding exception object.#12190diemol merged 2 commits intoSeleniumHQ:trunkfrom
errorhandler.py to corresponding exception object.#12190diemol merged 2 commits intoSeleniumHQ:trunkfrom
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## trunk #12190 +/- ##
==========================================
+ Coverage 56.56% 56.89% +0.32%
==========================================
Files 86 86
Lines 5450 5428 -22
Branches 223 226 +3
==========================================
+ Hits 3083 3088 +5
+ Misses 2144 2114 -30
- Partials 223 226 +3
☔ View full report in Codecov by Sentry. |
diemol
approved these changes
Jun 12, 2023
Member
diemol
left a comment
diemol
left a comment
There was a problem hiding this comment.
Thank you, @sandeepsuryaprasad!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Mapped all error codes in
ErrorCodeobject inremote/errorhandler.pyto corresponding exception object by creating a new objectExceptionMapping.Motivation and Context
In
ErrorHandlerobject inremote/errorhandler.py, there is a giant conditional statement which actually assigns an exception object to a variableexception_classdepending onstatus.All error codes and its corresponding values are maintained in
ErrorCodeobject. Through multiple conditional statements, an exception object is being assigned to variableexception_classdepending onstatusin response.I have mapped all error codes in
ErrorCodeobject and its corresponding exception object in a separateExceptionClassobject, so that multipleif-elif-elseblock is avoided inErrorHandlerobject.Added a new logic to assign
exception_classvariable by replacing conditional statements. Now the code inErrorHandlerobject is reduced to a great extent.Types of changes
Checklist