[bazel][java] Limit usage of io.opentelemetry dependencies#12164
Merged
diemol merged 2 commits intoSeleniumHQ:trunkfrom Jun 28, 2023
Merged
[bazel][java] Limit usage of io.opentelemetry dependencies#12164diemol merged 2 commits intoSeleniumHQ:trunkfrom
diemol merged 2 commits intoSeleniumHQ:trunkfrom
Conversation
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## trunk #12164 +/- ##
=======================================
Coverage 56.52% 56.52%
=======================================
Files 86 86
Lines 5454 5454
Branches 223 223
=======================================
Hits 3083 3083
Misses 2148 2148
Partials 223 223 ☔ View full report in Codecov by Sentry. |
joerg1985
changed the title
Member
Author
|
@diemol could you please have a look at this one, this will remove 13 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change will remove the
io.opentelemetrydependencies where not needed.If one must set the
Contextto anOpenTelemetryTracerthis can be still made by using ainstanceOfcheck and cast aTracerto theOpenTelemetryTracerto callsetOpenTelemetryContext.Motivation and Context
Will further reduce the dependencies needed in the java client bindings.
Types of changes
Checklist