Skip to content

[grid] Deleted all javax.servlet related code#12149

Merged
diemol merged 3 commits intoSeleniumHQ:trunkfrom
joerg1985:javax-servlet
Jun 6, 2023
Merged

[grid] Deleted all javax.servlet related code#12149
diemol merged 3 commits intoSeleniumHQ:trunkfrom
joerg1985:javax-servlet

Conversation

@joerg1985
Copy link
Copy Markdown
Member

Description

This PR will deleted all javax.servlet related code, i guess these files are leftover from a earlier grid server implementation.

Motivation and Context

Less code to maintain, please stop me if going too far with the clean up.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Copy Markdown
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @joerg1985!

@diemol diemol merged commit 6e8760a into SeleniumHQ:trunk Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants