Skip to content

[js][bidi] Script Module Add/Remove preload script command#12117

Merged
harsha509 merged 2 commits intoSeleniumHQ:trunkfrom
TamsilAmani:js-bidi-preloadscript
May 31, 2023
Merged

[js][bidi] Script Module Add/Remove preload script command#12117
harsha509 merged 2 commits intoSeleniumHQ:trunkfrom
TamsilAmani:js-bidi-preloadscript

Conversation

@TamsilAmani
Copy link
Copy Markdown
Contributor

@TamsilAmani TamsilAmani commented May 30, 2023

Description

This PR adds the BiDi script module commands for Add and Remove preload script.
Corresponding tests for all the functions are written. The code for the 'arguments' parameter and its test will be done later.

Motivation and Context

#11979

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@TamsilAmani TamsilAmani requested a review from harsha509 May 30, 2023 22:03
@harsha509
Copy link
Copy Markdown
Member

js checks looks good to me!

@harsha509 harsha509 merged commit c1e47d3 into SeleniumHQ:trunk May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants