Skip to content

[py] support Proxies with Selenium Manager#12032

Merged
titusfortner merged 1 commit intotrunkfrom
py_proxy_sm
May 25, 2023
Merged

[py] support Proxies with Selenium Manager#12032
titusfortner merged 1 commit intotrunkfrom
py_proxy_sm

Conversation

@titusfortner
Copy link
Copy Markdown
Member

@titusfortner titusfortner commented May 14, 2023

I'm making this a Draft PR instead of merging it, because it depends on #12029 and I'd like someone with more Python chops to make sure that's good before we merge this one.

This is for Python solution to #11294

I tested it and made sure it worked locally.

@titusfortner titusfortner changed the title Py proxy sm [py] support Proxies with Selenium Manager May 14, 2023
@titusfortner titusfortner added the C-py Python Bindings label May 14, 2023
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 14, 2023

Codecov Report

Patch coverage: 20.00% and project coverage change: -0.04 ⚠️

Comparison is base (6a776f3) 54.86% compared to head (0e5fe95) 54.83%.

❗ Current head 0e5fe95 differs from pull request most recent head 3dec0ae. Consider uploading reports for the commit 3dec0ae to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #12032      +/-   ##
==========================================
- Coverage   54.86%   54.83%   -0.04%     
==========================================
  Files          86       86              
  Lines        5725     5730       +5     
  Branches      233      233              
==========================================
+ Hits         3141     3142       +1     
- Misses       2351     2355       +4     
  Partials      233      233              
Impacted Files Coverage Δ
py/selenium/webdriver/common/selenium_manager.py 63.49% <20.00%> (-3.75%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@titusfortner titusfortner added this to the 4.10 milestone May 18, 2023
@titusfortner titusfortner marked this pull request as ready for review May 25, 2023 20:42
@titusfortner titusfortner merged commit 5b40670 into trunk May 25, 2023
@titusfortner titusfortner deleted the py_proxy_sm branch May 25, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-py Python Bindings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants