Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## trunk #12030 +/- ##
==========================================
- Coverage 55.93% 55.69% -0.25%
==========================================
Files 86 86
Lines 5746 5421 -325
Branches 233 223 -10
==========================================
- Hits 3214 3019 -195
+ Misses 2299 2179 -120
+ Partials 233 223 -10
☔ View full report in Codecov by Sentry. |
titusfortner
force-pushed
the
py_deps
branch
2 times, most recently
from
cc7cf9e to
16c16a6
Compare
titusfortner
force-pushed
the
py_deps
branch
6 times, most recently
from
3734122 to
42a19ba
Compare
Member
|
Initial review and looks ok |
titusfortner
force-pushed
the
py_deps
branch
2 times, most recently
from
9a89264 to
1fce40c
Compare
diemol
approved these changes
May 28, 2023
AutomatedTester
approved these changes
May 31, 2023
Member
Author
|
I tried a few things to get the lint test passing on CI, and nothing is working. Not sure how to proceed since things are passing just fine for me locally. |
9 tasks
evansd
added a commit
to bennettoxford/openprescribing
that referenced
this pull request
Dec 14, 2023
This will allow us to update Selenium. I determined the changes needed here by looking at the PR which removed the deprecated code and working backwards: SeleniumHQ/selenium#12030
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
get_remote_connection()is kind of a clever hack to be able to use browser specific methods in remote webdriver class. I would love if we can get a mixin or something to better support these. Regardless, what is there currently does not work for Chrome or Edge because thebrowser_nameof theChromiumRemoteConnectionisNone._ignore_local_proxywhich is currently getting set in Options. Anyway, future PR.Motivation and Context
It's really difficult to see what is going on in Python code with deprecations everywhere
All of this has been deprecated since 4.0 or earlier.
I'm honestly not sure when to set things to self and when not to, and when to reference things as self, so this code can probably be cleaned up even more.