[py] fix proxy options#12029
Merged
titusfortner merged 1 commit intotrunkfrom May 25, 2023
Merged
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## trunk #12029 +/- ##
==========================================
+ Coverage 54.85% 54.86% +0.01%
==========================================
Files 86 86
Lines 5728 5725 -3
Branches 233 233
==========================================
- Hits 3142 3141 -1
+ Misses 2353 2351 -2
Partials 233 233
☔ View full report in Codecov by Sentry. |
titusfortner
force-pushed
the
py_proxy
branch
8 times, most recently
from
34f9d34 to
a4a456a
Compare
diemol
reviewed
May 24, 2023
Member
diemol
left a comment
diemol
left a comment
There was a problem hiding this comment.
This looks fine to me, but wondering what @AutomatedTester and @symonk think.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow Proxy to be used in any browser
Motivation and Context
I added proxy property to Base Options class right before Se 4.0, but I didn't add the part that would actually add it to the capabilities. So right now I think proxy only works as intended for Firefox.
I'm removing
add_to_capabilities()because it's a weird way to serialize a class, and also because capabilities is deprecated so no one should be passing it around. If we're just using options class, then we just need a way to serialize it, so I'm renaming the logicto_capabilities(). When we serialize it in options, we don't have to add logic in remote webdriver class.