Skip to content

[dotnet] Using SM in default service creation#11994

Merged
diemol merged 3 commits intotrunkfrom
use-sm-in-default-service-creation
May 5, 2023
Merged

[dotnet] Using SM in default service creation#11994
diemol merged 3 commits intotrunkfrom
use-sm-in-default-service-creation

Conversation

@diemol
Copy link
Copy Markdown
Member

@diemol diemol commented May 4, 2023 •
edited
Loading

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Fixes #11942

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@diemol diemol merged commit 0ce64cb into trunk May 5, 2023
@diemol diemol deleted the use-sm-in-default-service-creation branch May 5, 2023 11:47
@titusfortner
Copy link
Copy Markdown
Member

titusfortner commented Jun 11, 2023

Hmm, we just deprecated passing in the options instance to the service class in Java.

I don't think #11942 is a valid use case. If you want to start the driver without creating a new session (why?), either specify the location explicitly or add the line to verify the service path directly. I think we should revert this one. (sorry for not looking more closely earlier)

With DriverFinder code added:

using ChromeDriverService service = ChromeDriverService.CreateDefaultService();
service.EnableVerboseLogging = true;
service.SuppressInitialDiagnosticInformation = false;

DriverFinder.VerifyDriverServicePath(service, new ChromeOptions())

if (!service.IsRunning)
{
    service.Start();
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

It seems FindDriverServiceExecutable has not been updated to use SeleniumManager in version 4.9?

2 participants

@diemol @titusfortner