Skip to content

Putting the logic to verify driver service path in a single place#11992

Merged
diemol merged 4 commits intotrunkfrom
refactor-verify-driver-service-path
May 4, 2023
Merged

Putting the logic to verify driver service path in a single place#11992
diemol merged 4 commits intotrunkfrom
refactor-verify-driver-service-path

Conversation

@diemol
Copy link
Copy Markdown
Member

@diemol diemol commented May 4, 2023

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@diemol
Copy link
Copy Markdown
Member Author

diemol commented May 4, 2023

Failing tests are not related to the change. Need to debug them on a Windows machine.

@diemol diemol merged commit 0dbec9d into trunk May 4, 2023
@diemol diemol deleted the refactor-verify-driver-service-path branch May 4, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant