Conversation
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## trunk #11990 +/- ##
==========================================
- Coverage 54.89% 54.85% -0.04%
==========================================
Files 86 86
Lines 5733 5728 -5
Branches 233 233
==========================================
- Hits 3147 3142 -5
Misses 2353 2353
Partials 233 233
☔ View full report in Codecov by Sentry. |
diemol
approved these changes
May 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Log more things for Selenium Manager
Removes a browser check that shouldn't be necessary. We're using options instances, but if a browserName is set that isn't recognized, SM will give the appropriate error.
Motivation and Context
Match what is being done in other languages
Need to be able to see more details for Selenium Manager issues