Skip to content

[py] minor fixes for docstring and dictionary declarations#11975

Merged
diemol merged 4 commits intoSeleniumHQ:trunkfrom
iampopovich:py-work-branch
May 2, 2023
Merged

[py] minor fixes for docstring and dictionary declarations#11975
diemol merged 4 commits intoSeleniumHQ:trunkfrom
iampopovich:py-work-branch

Conversation

@iampopovich
Copy link
Copy Markdown
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

some minor improvements of code with adding a new parameter to docstring and replacing two dictionary declarations to dictionary literal syntax

Motivation and Context

improving code readability

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@iampopovich iampopovich changed the title minor fixes for docstring and dictionary declarations [py] minor fixes for docstring and dictionary declarations May 1, 2023
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (9ac368b) 54.87% compared to head (279a388) 54.89%.

❗ Current head 279a388 differs from pull request most recent head 8280b3b. Consider uploading reports for the commit 8280b3b to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #11975      +/-   ##
==========================================
+ Coverage   54.87%   54.89%   +0.01%     
==========================================
  Files          86       86              
  Lines        5735     5733       -2     
  Branches      233      233              
==========================================
  Hits         3147     3147              
+ Misses       2355     2353       -2     
  Partials      233      233              
Impacted Files Coverage Δ
py/selenium/webdriver/common/proxy.py 17.28% <0.00%> (+0.10%) ⬆️
py/selenium/webdriver/firefox/webdriver.py 53.41% <ø> (ø)
py/selenium/webdriver/safari/webdriver.py 57.14% <0.00%> (+0.67%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @iampopovich!

@diemol diemol merged commit 38cbd00 into SeleniumHQ:trunk May 2, 2023
@iampopovich iampopovich deleted the py-work-branch branch June 1, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants