[java] simplified some control flows logic and removed unused imports#11974
Merged
diemol merged 14 commits intoSeleniumHQ:trunkfrom May 17, 2023
iampopovich:java-wip-branch
Merged
[java] simplified some control flows logic and removed unused imports#11974diemol merged 14 commits intoSeleniumHQ:trunkfrom iampopovich:java-wip-branch
diemol merged 14 commits intoSeleniumHQ:trunkfrom
iampopovich:java-wip-branch
Conversation
Codecov ReportPatch and project coverage have no change.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## trunk #11974 +/- ##
=======================================
Coverage 54.85% 54.85%
=======================================
Files 86 86
Lines 5728 5728
Branches 233 233
=======================================
Hits 3142 3142
Misses 2353 2353
Partials 233 233 ☔ View full report in Codecov by Sentry. |
diemol
requested changes
May 15, 2023
Member
diemol
left a comment
diemol
left a comment
There was a problem hiding this comment.
Thank you for this PR. I left a small comment.
diemol
requested changes
May 16, 2023
fix imports after conflict
diemol
approved these changes
May 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
changes are provided to increase code readability
removing unused imports provided to increase code clearness and decrease build time also
Motivation and Context
Types of changes
Checklist