Conversation
…the timeout value Users should be using the builder
Allow log level to be set in service class, not just in options class Allow Toggling truncation of log lines Allow users to specify a different location for profile creation
…vers This allows completely silencing all logging output or directing everything from the process to a specified file
diemol
requested changes
May 2, 2023
diemol
approved these changes
May 3, 2023
Codecov ReportPatch and project coverage have no change.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## trunk #11973 +/- ##
=======================================
Coverage 54.89% 54.89%
=======================================
Files 86 86
Lines 5733 5733
Branches 233 233
=======================================
Hits 3147 3147
Misses 2353 2353
Partials 233 233 ☔ View full report in Codecov by Sentry. |
diemol
approved these changes
May 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Different drivers currently have different behaviors. This brings everything into agreement.
Motivation and Context
Addresses #11643
This is also in accordance with what we discussed in #11410 as well as:
Specifics:
FirefoxBinaryrelated)The last item is the biggest one. By default geckodriver logs everything at an INFO level to stderr. This is annoying, so it was allowed to use the System Property
webdriver.firefox.logLevelto set the"/dev/null"for it to discard the output. But only being able to do this by using a system property is bad, so I added methods and support for it in all browsers.For comparison, Ruby has always sent everything from driver process to null output as a default.
This PR allows either of these:
or