Skip to content

[java] Webdriver can work with embedded apps without CDP#11963

Merged
diemol merged 19 commits intoSeleniumHQ:trunkfrom
vlad8x8:patch-1
May 17, 2023
Merged

[java] Webdriver can work with embedded apps without CDP#11963
diemol merged 19 commits intoSeleniumHQ:trunkfrom
vlad8x8:patch-1

Conversation

@vlad8x8
Copy link
Copy Markdown
Contributor

@vlad8x8 vlad8x8 commented Apr 27, 2023 •
edited
Loading

Webdriver for New MS Teams can start only added an argument remote-debugging-port=<any number> to EdgeOptions. But Teams is actually staring at random port and ChromiumDriver is failing to create a CDP connection. If the connection is empty, Teams starts well and webdriver can interact with Teams well.

Description

Connection can be empty if CromiumDriver can not create it

Motivation and Context

CromiumDriver can't connect to New MS Teams

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@vlad8x8
Connection can be empty for embedded apps
3daab89 
Webdriver for New MS Teams can start only added an argument `remote-debugging-port=<any number>` to EdgeOptions. But Teams is actually staring at random port and ChromiumDriver is failing to create a connection.
If the connection is empty, Teams starts well and webdriver can interact with Teams well.
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 27, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

diemol
diemol reviewed May 1, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR.

Could you please share more information or a link about this use case? We'd probably be fine with this change, but I would like to document the change after understanding the intent better.

@vlad8x8
Copy link
Copy Markdown
Contributor Author

vlad8x8 commented May 1, 2023 •
edited
Loading

Thank you for your PR.

Could you please share more information or a link about this use case? We'd probably be fine with this change, but I would like to document the change after understanding the intent better.

As mentioned in the description, the main use case is The New MS Teams (https://adoption.microsoft.com/en-us/new-microsoft-teams/) based on Edge browser.
I'm sorry, but I don't clearly understand how that connection is working, but locally I just set in debugging connection = empty and it's running well

diemol
diemol requested changes May 2, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please check? The code is not building. https://github.com/SeleniumHQ/selenium/actions/runs/4859217466/jobs/8661644754

@vlad8x8 vlad8x8 requested a review from diemol May 2, 2023 14:17
@vlad8x8
Copy link
Copy Markdown
Contributor Author

vlad8x8 commented May 5, 2023

Could you please check? The code is not building. SeleniumHQ/selenium/actions/runs/4859217466/jobs/8661644754

fixed

@vlad8x8
Copy link
Copy Markdown
Contributor Author

vlad8x8 commented May 8, 2023

Hi @diemol
Could you please re-review the PR?

@vlad8x8 vlad8x8 changed the title Connection can be empty for embedded apps [java] Connection can be empty for embedded apps May 8, 2023
@vlad8x8 vlad8x8 changed the title [java] Connection can be empty for embedded apps [java] Webdriver can work with embedded apps without CDP May 10, 2023
@vlad8x8
Copy link
Copy Markdown
Contributor Author

vlad8x8 commented May 11, 2023

Hi @diemol
Could you please review the requested change?

@titusfortner
Copy link
Copy Markdown
Member

titusfortner commented May 12, 2023

He's on holiday. Thanks for the PR, but we'll get to it when we can.

diemol
diemol approved these changes May 17, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @vlad8x8!

@diemol diemol merged commit 4bf1d68 into SeleniumHQ:trunk May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diemol diemol diemol approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vlad8x8 @CLAassistant @titusfortner @diemol