[dotnet] Use ChangeType method to convert any object to boolean in WebElement propoerties#11913
Merged
diemol merged 1 commit intoSeleniumHQ:trunkfrom Apr 19, 2023
nvborisenko:safe-conversion
Merged
[dotnet] Use ChangeType method to convert any object to boolean in WebElement propoerties#11913diemol merged 1 commit intoSeleniumHQ:trunkfrom nvborisenko:safe-conversion
diemol merged 1 commit intoSeleniumHQ:trunkfrom
nvborisenko:safe-conversion
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This approach brings us a possibility to track what exactly we try to convert.
Description
It always throws
InvalidCastException.There is safer method:
Even if input is not formatted well to be boolean, then we will get more clear exception:
where
false 66is incorrect input.Motivation and Context
Just to get more clear understanding what is going wrong, and highlight a value returned from server side.
Types of changes
Checklist