scrapped refactors from old PR#11907
Merged
diemol merged 4 commits intoSeleniumHQ:trunkfrom Apr 19, 2023
Merged
Conversation
bonigarcia
requested changes
Apr 17, 2023
Member
|
@dev-ardi would you like to continue working on this PR? We are about to do a release soon and wanted to know if we could have this as part of the release. |
Contributor
Author
|
@diemol sure, it's a very minor PR but I can try to get some time and finish it today :) |
bonigarcia
approved these changes
Apr 19, 2023
bonigarcia
approved these changes
Apr 19, 2023
diemol
approved these changes
Apr 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Apply refactors from #11837
Types of changes
Checklist