Skip to content

scrapped refactors from old PR#11907

Merged
diemol merged 4 commits intoSeleniumHQ:trunkfrom
oriongonza:scrapped-refactors
Apr 19, 2023
Merged

scrapped refactors from old PR#11907
diemol merged 4 commits intoSeleniumHQ:trunkfrom
oriongonza:scrapped-refactors

Conversation

@oriongonza
Copy link
Copy Markdown
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Apply refactors from #11837

  • I delete clone from config as it's not needed anymore
  • I change some owned types that don't need to be to references
  • Pattern matching for str_to_os

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

@diemol diemol requested a review from bonigarcia April 16, 2023 20:43
Comment thread rust/src/config.rs Outdated
@diemol
Copy link
Copy Markdown
Member

diemol commented Apr 19, 2023

@dev-ardi would you like to continue working on this PR? We are about to do a release soon and wanted to know if we could have this as part of the release.

@oriongonza
Copy link
Copy Markdown
Contributor Author

@diemol sure, it's a very minor PR but I can try to get some time and finish it today :)

Copy link
Copy Markdown
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @dev-ardi!

@diemol diemol merged commit bd7bdcb into SeleniumHQ:trunk Apr 19, 2023
@oriongonza oriongonza deleted the scrapped-refactors branch April 19, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants