[js] fix: return statement in submit()#11883
Merged
titusfortner merged 2 commits intoSeleniumHQ:trunkfrom Apr 18, 2023
Merged
Conversation
Member
|
Makes sense! Thank you @TamsilAmani ! |
Member
|
What result are we expecting from submit? It's an action on the browser, so the return should be |
harsha509
dismissed
their stale review
Checked the code again after @titusfortner comment, looks like it is only returning null. Do you have any use case tamsil ?
|
@titusfortner @harsha509 I stumbled upon this bug while working on Nightwatch. The problem is that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The value evaluated by the submit() was not being returned.
Motivation and Context
Help developers who use selenium to get correct result.
Types of changes
Checklist