Skip to content

[rust] Remove short flags in selenium-manager#11882

Merged
diemol merged 2 commits intotrunkfrom
se_mgr_short
Apr 13, 2023
Merged

[rust] Remove short flags in selenium-manager#11882
diemol merged 2 commits intotrunkfrom
se_mgr_short

Conversation

@bonigarcia
Copy link
Copy Markdown
Member

Description

This PR removes the use of short flags (e.g., -b for browsers) leaving only the long flags (e.g., --browser).

Motivation and Context

There is a quite long lists of CLI flags at the moment in selenium-manager (e.g. --browser, --driver, etc.), and this list is supposed to be longer in the future. For this reason, it is difficult to find meaningful short flavour of these options. Moreover, there are two options (--driver-ttl and --browser-ttl, both created by external PRs) without the short flag.

This PR unifies the criteria for the selenium-manager flags, removing all the short flags. Also, this PR updated the rust README (which contains the --help of selenium-manager).

NOTE: I checked that all bindings use the long flags (i.e., --browser or --driver), so this change should not break anything in the bindings.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bonigarcia bonigarcia added the C-rust Rust code is mostly Selenium Manager label Apr 11, 2023
Copy link
Copy Markdown
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @bonigarcia!

@diemol diemol merged commit 4548ce8 into trunk Apr 13, 2023
@diemol diemol deleted the se_mgr_short branch April 13, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-rust Rust code is mostly Selenium Manager

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants