[rust] Now the logger accepts any kind of type that can be converted to string#11865
Merged
diemol merged 4 commits intoSeleniumHQ:trunkfrom Apr 17, 2023
Merged
[rust] Now the logger accepts any kind of type that can be converted to string#11865diemol merged 4 commits intoSeleniumHQ:trunkfrom
diemol merged 4 commits intoSeleniumHQ:trunkfrom
Conversation
oriongonza
changed the title
bonigarcia
requested changes
Apr 5, 2023
Member
bonigarcia
left a comment
bonigarcia
left a comment
There was a problem hiding this comment.
There are compilation errors. Also, please verify that all tests pass with the new changes (cargo test).
Contributor
Author
|
@bonigarcia I'm sorry for the really long wait! I have merged and it should work now. |
bonigarcia
approved these changes
Apr 17, 2023
Member
bonigarcia
left a comment
bonigarcia
left a comment
There was a problem hiding this comment.
LGTM. Thanks a lot, @dev-ardi!
diemol
approved these changes
Apr 17, 2023
Member
diemol
left a comment
diemol
left a comment
There was a problem hiding this comment.
Thank you for reviewing, @bonigarcia!
Thank you, @dev-ardi!
This was referenced Apr 17, 2023
Member
|
This commit broke the |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Now the logger accepts any kind of type that can be converted to string
Motivation and Context
Enable fix of #11810 (comment)
Types of changes
Checklist