[dotnet] Don't listen to error output stream from selenium manager to avoid messing up output#11863
Merged
diemol merged 3 commits intoSeleniumHQ:trunkfrom Apr 5, 2023
nvborisenko:fix-se-error-output
Merged
[dotnet] Don't listen to error output stream from selenium manager to avoid messing up output#11863diemol merged 3 commits intoSeleniumHQ:trunkfrom nvborisenko:fix-se-error-output
diemol merged 3 commits intoSeleniumHQ:trunkfrom
nvborisenko:fix-se-error-output
Conversation
Member
Author
|
Forgot to mention my synthetic test passes now, which invoked selenium manager 1K times. Output from SM handled correctly. |
yashcho
pushed a commit
to yashcho/selenium
that referenced
this pull request
Apr 7, 2023
… avoid messing up output (SeleniumHQ#11863) Don't listen to error output stream from selenium manager Co-authored-by: Diego Molina <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There is a race condition when output of error stream from selenium manager may be messed with output from standard stream. Since we expect standard output in json format, then it might break json structure. I played around it and discovered it might happen 1 out of 200 times (created synthetic test against selenium manager).
Motivation and Context
Using selenium manager in dotnet sometimes fails without error. My test fails sporadically. This PR fixes one of the possible "hidden" errors.
Types of changes
Checklist
Notes for future
If we will need to listen error output, then we can apply the same mechanism, but store output in different object which is not shared with standard output.
Details
This is my synthetic test: it outputs the webdriver path given from selenium manager.
Sometimes the path is incorrect.