Skip to content

Fix documentation for auto downloads feature#11853

Merged
diemol merged 2 commits intoSeleniumHQ:trunkfrom
krmahadevan:fix_documentation_for_managed_downloads
Apr 3, 2023
Merged

Fix documentation for auto downloads feature#11853
diemol merged 2 commits intoSeleniumHQ:trunkfrom
krmahadevan:fix_documentation_for_managed_downloads

Conversation

@krmahadevan
Copy link
Copy Markdown
Contributor

@krmahadevan krmahadevan commented Apr 1, 2023

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@krmahadevan krmahadevan requested a review from diemol April 1, 2023 03:42
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (43318cb) 54.83% compared to head (ad6dedf) 54.83%.

❗ Current head ad6dedf differs from pull request most recent head 4a22c6b. Consider uploading reports for the commit 4a22c6b to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@           Coverage Diff           @@
##            trunk   #11853   +/-   ##
=======================================
  Coverage   54.83%   54.83%           
=======================================
  Files          85       85           
  Lines        5693     5693           
  Branches      230      230           
=======================================
  Hits         3122     3122           
  Misses       2341     2341           
  Partials      230      230

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

diemol
diemol approved these changes Apr 3, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @krmahadevan!

@diemol diemol merged commit e90e786 into SeleniumHQ:trunk Apr 3, 2023
yashcho pushed a commit to yashcho/selenium that referenced this pull request Apr 7, 2023
@krmahadevan @yashcho
Fix documentation for auto downloads feature (SeleniumHQ#11853)
9614ec0 
[skip ci]
@krmahadevan krmahadevan deleted the fix_documentation_for_managed_downloads branch April 12, 2023 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diemol diemol diemol approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@krmahadevan @codecov-commenter @diemol