[JS][BiDi] Add Script module commands and types#11847
Merged
harsha509 merged 5 commits intoSeleniumHQ:trunkfrom Apr 10, 2023
Merged
[JS][BiDi] Add Script module commands and types#11847harsha509 merged 5 commits intoSeleniumHQ:trunkfrom
harsha509 merged 5 commits intoSeleniumHQ:trunkfrom
Conversation
Contributor
Author
|
I suggest to add getter functions where ever possible instead of directly accessing the object's attributes. Is that okay? |
harsha509
reviewed
Apr 3, 2023
TamsilAmani
force-pushed
the
js-bidi-script
branch
from
61c2e55 to
fc256a4
Compare
Contributor
Author
|
Thank you for the review @harsha509. I have pushed the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add script module commands and types
Motivation and Context
Implement script module commands and types as described in https://w3c.github.io/webdriver-bidi/#module-script.
The majority of classes and interfaces are mapping the common data types as described in https://w3c.github.io/webdriver-bidi/#data-types.
Types of changes
Checklist