Skip to content

[rust] simplify get_metadata_path method invoke#11835

Merged
diemol merged 4 commits intoSeleniumHQ:trunkfrom
iampopovich:fix-metadata-path-invoke
Apr 5, 2023
Merged

[rust] simplify get_metadata_path method invoke#11835
diemol merged 4 commits intoSeleniumHQ:trunkfrom
iampopovich:fix-metadata-path-invoke

Conversation

@iampopovich
Copy link
Copy Markdown
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

i've replaced the statement for metadata_path variable with special method get_metadata_path

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@iampopovich iampopovich changed the title simplify get_metadata_path method invoke [rust] simplify get_metadata_path method invoke Mar 30, 2023
@titusfortner titusfortner requested a review from bonigarcia March 30, 2023 14:33
Copy link
Copy Markdown
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @iampopovich!

@diemol diemol merged commit 51f48ca into SeleniumHQ:trunk Apr 5, 2023
yashcho pushed a commit to yashcho/selenium that referenced this pull request Apr 7, 2023
simplify get_metadata_path method invoke

Co-authored-by: Diego Molina <[email protected]>
@iampopovich iampopovich deleted the fix-metadata-path-invoke branch April 30, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants