[Rust] Refactors#11832
Conversation
|
|
bonigarcia
left a comment
bonigarcia
left a comment
There was a problem hiding this comment.
Hi @dev-ardi. Are you using cargo fmt to format the code in this PR?
|
Buenos días @bonigarcia, Yes I am, that's the reason behind the commit ac551af |
|
We also use cargo fmt, thanks! |
|
@dev-ardi could you please sign the CLA and resolve the conflicts? |
|
Done |
|
I have no idea how to merge these locally😞 |
|
You can use the GitHub UI for that...
|
|
@dev-ardi hey, we have numerous chat services all interconnected if you're interested. https://www.selenium.dev/support/ It might mean you get quicker answers as people might not always be watching GitHub notifications. We would love for you to join us and come hang out |
* Refactor so that it's more concise * cargo fmt * I found it too verbose * String interpolation * Since the error message is the same now put it in the chain. * Added never return type so I can remove the calls to exit() --------- Co-authored-by: ogonzalez <[email protected]> Co-authored-by: Diego Molina <[email protected]>
6 participants
Description
General refactors in the selenium manager
Motivation and Context
I was going to add a new functionality and found some code that could get updated.
Checklist
Changes
if let Errsyntax if this change is not accepted