Skip to content

[java][bidi] Add browsing context events support#11759

Merged
diemol merged 5 commits intoSeleniumHQ:trunkfrom
pujagani:browsing-context-events
Jun 1, 2023
Merged

[java][bidi] Add browsing context events support#11759
diemol merged 5 commits intoSeleniumHQ:trunkfrom
pujagani:browsing-context-events

Conversation

@pujagani
Copy link
Copy Markdown
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Add browsing context events support

Motivation and Context

W3C BiDi spec defines events related to a browsing context. The changes implement APIs to allow users to listen to those events. https://w3c.github.io/webdriver-bidi/#module-contexts-events.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Patch and project coverage have no change.

Comparison is base (8a73d50) 55.93% compared to head (0ef9c35) 55.93%.

❗ Current head 0ef9c35 differs from pull request most recent head 25cb2e2. Consider uploading reports for the commit 25cb2e2 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #11759   +/-   ##
=======================================
  Coverage   55.93%   55.93%           
=======================================
  Files          86       86           
  Lines        5746     5746           
  Branches      233      233           
=======================================
  Hits         3214     3214           
  Misses       2299     2299           
  Partials      233      233           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @pujagani!

@diemol diemol merged commit 4f076e0 into SeleniumHQ:trunk Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants