Skip to content

[rust] Selenium Manager parse mirror to get latest IEDriverServer version (#11672)#11722

Merged
bonigarcia merged 1 commit intotrunkfrom
se_mgr_ie_mirror
Mar 1, 2023
Merged

[rust] Selenium Manager parse mirror to get latest IEDriverServer version (#11672)#11722
bonigarcia merged 1 commit intotrunkfrom
se_mgr_ie_mirror

Conversation

@bonigarcia
Copy link
Copy Markdown
Member

Description

Currently, Selenium Manager assumes that the latest release of Selenium contains a version of IEDriverServer. This can pose a potential problem if a Selenium release does not ship the IEDriverServer binaries. To avoid this potential problem, this PR uses the mirrored responses of the GH API to discover the latest IEDriverServer version.

Motivation and Context

This PR closes #11672.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Comment thread rust/src/mirror.rs
@bonigarcia bonigarcia merged commit c483b0f into trunk Mar 1, 2023
@bonigarcia bonigarcia deleted the se_mgr_ie_mirror branch March 1, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[🚀 Feature]: Selenium Manager uses proper IEDriverSever version

2 participants