Skip to content

Remove newline to enable hyperlink in VS Code#11719

Merged
diemol merged 1 commit intoSeleniumHQ:trunkfrom
MMK-IBSEN:patch-1
Mar 1, 2023
Merged

Remove newline to enable hyperlink in VS Code#11719
diemol merged 1 commit intoSeleniumHQ:trunkfrom
MMK-IBSEN:patch-1

Conversation

@MMK-IBSEN
Copy link
Copy Markdown
Contributor

@MMK-IBSEN MMK-IBSEN commented Mar 1, 2023

Description

When inspecting/hovering over the Edge class in VS Code, the link for the MSEdgedriver executable does not correctly display as a hyperlink, as seen in the picture below.

Hyperlink_fail

Removing the newline here should fix the problem.

I only have the Python VS code extenstion is installed.

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

When inspecting/hovering over the Edge class in VS Code, the link for the MSEdgedriver executable does not correctly display as a hyperlink.

Removing the newline here should fix the problem.

I only have the Python VS code extenstion is installed.
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 1, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Copy Markdown
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @MMK-IBSEN!

@diemol diemol merged commit 7d233ef into SeleniumHQ:trunk Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants