[grid] Using the temp file system utility

With this, it will be transparent for the user where files are written, and since we use the caches then the deletion happens when the session is closed. Also, we do not need the `--base-dir-downloads` parameter.
SeleniumHQ · diemol · Mar 15, 2023 · Jan 29, 2023 · Mar 13, 2023 · Mar 13, 2023
commit 729f71b919046dc469688a8f7e346ed20973cff7
diff --git a/java/src/org/openqa/selenium/grid/node/Node.java b/java/src/org/openqa/selenium/grid/node/Node.java
@@ -18,9 +18,11 @@
 package org.openqa.selenium.grid.node;
 
 import com.google.common.collect.ImmutableMap;
+
 import org.openqa.selenium.BuildInfo;
 import org.openqa.selenium.Capabilities;
 import org.openqa.selenium.NoSuchSessionException;
+import org.openqa.selenium.WebDriverException;
 import org.openqa.selenium.grid.data.CreateSessionRequest;
 import org.openqa.selenium.grid.data.CreateSessionResponse;
 import org.openqa.selenium.grid.data.NodeId;
@@ -41,13 +43,13 @@
 import org.openqa.selenium.remote.tracing.SpanDecorator;
 import org.openqa.selenium.remote.tracing.Tracer;
 import org.openqa.selenium.status.HasReadyState;
-import org.openqa.selenium.WebDriverException;
 
 import java.io.IOException;
 import java.net.URI;
 import java.util.Map;
 import java.util.ServiceLoader;
 import java.util.Set;
+import java.util.UUID;
 import java.util.logging.Logger;
 import java.util.stream.Collectors;
 import java.util.stream.StreamSupport;
@@ -210,16 +212,21 @@ public ImmutableMap<String, String> getOsInfo() {
     return OS_INFO;
   }
 
-  public abstract Either<WebDriverException, CreateSessionResponse> newSession(CreateSessionRequest sessionRequest);
+  public abstract Either<WebDriverException, CreateSessionResponse> newSession(
+    CreateSessionRequest sessionRequest);
 
   public abstract HttpResponse executeWebDriverCommand(HttpRequest req);
 
   public abstract Session getSession(SessionId id) throws NoSuchSessionException;
 
-  public TemporaryFilesystem getTemporaryFilesystem(SessionId id) throws IOException {
+  public TemporaryFilesystem getUploadsFilesystem(SessionId id) throws IOException {
     throw new UnsupportedOperationException();
   }
 
+  public TemporaryFilesystem getDownloadsFilesystem(UUID uuid) throws IOException {
+    throw new UnsupportedOperationException();
+  }
+
   public abstract HttpResponse uploadFile(HttpRequest req, SessionId id);
 
   public abstract HttpResponse downloadFile(HttpRequest req, SessionId id);

diff --git a/java/src/org/openqa/selenium/grid/node/config/NodeFlags.java b/java/src/org/openqa/selenium/grid/node/config/NodeFlags.java
@@ -240,13 +240,6 @@ public class NodeFlags implements HasRoles {
   @ConfigValue(section = NODE_SECTION, name = "enable-managed-downloads", example = "false")
   public Boolean managedDownloadsEnabled;
 
-  @Parameter(
-    names = {"--base-dir-downloads"},
-    description = "The base directory into which all downloads would be saved. If no value "
-                  + "is specified then this defaults to the user's home directory.")
-  @ConfigValue(section = NODE_SECTION, name = "base-dir-downloads", example = "user.home")
-  public String downloadsBaseDir;
-
   @Override
   public Set<Role> getRoles() {
     return Collections.singleton(NODE_ROLE);

diff --git a/java/src/org/openqa/selenium/grid/node/config/NodeOptions.java b/java/src/org/openqa/selenium/grid/node/config/NodeOptions.java
@@ -155,11 +155,6 @@ public boolean isManagedDownloadsEnabled() {
       .orElse(Boolean.FALSE);
   }
 
-  public String downloadsBaseDirectory() {
-    return config.get(NODE_SECTION, "base-dir-downloads")
-      .orElse(System.getProperty("user.home"));
-  }
-
   public Node getNode() {
     return config.getClass(NODE_SECTION, "implementation", Node.class, DEFAULT_NODE_IMPLEMENTATION);
   }