Skip to content

Fix NPE regression in 4.8.0#11701

Merged
pujagani merged 1 commit intoSeleniumHQ:trunkfrom
Kouzukii:trunk
Feb 24, 2023
Merged

Fix NPE regression in 4.8.0#11701
pujagani merged 1 commit intoSeleniumHQ:trunkfrom
Kouzukii:trunk

Conversation

@Kouzukii
Copy link
Copy Markdown
Contributor

@Kouzukii Kouzukii commented Feb 23, 2023

Selenium 4.8.0 introduced a NullPointerException when a node is started with a browserName not in [chrome, firefox, microsoftedge]

Motivation and Context

We use a custom selenium node to run tests in a Safari browser, but when upgrading to 4.8.0 we could no longer start the node due to this NullPointerException.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@pujagani
Copy link
Copy Markdown
Contributor

pujagani commented Feb 24, 2023

Thank you for your contribution and for helping fix the issue. The changes look good to me. Waiting for the CI to pass then will merge it.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 24, 2023

Codecov Report

Base: 54.65% // Head: 54.65% // No change to project coverage 👍

Coverage data is based on head (5f0dd62) compared to base (c79cab5).
Patch has no changes to coverable lines.

❗ Current head 5f0dd62 differs from pull request most recent head e4df55f. Consider uploading reports for the commit e4df55f to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@           Coverage Diff           @@
##            trunk   #11701   +/-   ##
=======================================
  Coverage   54.65%   54.65%           
=======================================
  Files          85       85           
  Lines        5643     5643           
  Branches      244      244           
=======================================
  Hits         3084     3084           
  Misses       2315     2315           
  Partials      244      244

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pujagani pujagani merged commit ed0fe60 into SeleniumHQ:trunk Feb 24, 2023
@pujagani
Copy link
Copy Markdown
Contributor

pujagani commented Feb 24, 2023

Thank you @Kouzukii!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pujagani pujagani pujagani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Kouzukii @pujagani @codecov-commenter