[java] Process Selenium Manager output as JSON#11663
Conversation
bonigarcia
force-pushed
the
se_mgr_java_json_output
branch
2 times, most recently
from
cad08ad to
aa4ac9d
Compare
Codecov ReportPatch and project coverage have no change.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## trunk #11663 +/- ##
=======================================
Coverage 54.89% 54.89%
=======================================
Files 85 85
Lines 5684 5684
Branches 231 231
=======================================
Hits 3120 3120
Misses 2333 2333
Partials 231 231 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
diemol
left a comment
diemol
left a comment
There was a problem hiding this comment.
I made changes so Java uses Selenium Manager to run tests, do you think we can add a test for this? It can be just with the INFO.
diemol
force-pushed
the
se_mgr_java_json_output
branch
from
aa4ac9d to
0b59c47
Compare
bonigarcia
force-pushed
the
se_mgr_java_json_output
branch
from
0b59c47 to
db9e0da
Compare
Any Java test using Selenium Manager is going to use this JSON parsing. What do you mean by "just with the INFO"? |
bonigarcia
force-pushed
the
se_mgr_java_json_output
branch
from
db9e0da to
1ee4133
Compare
|
@diemol This PR had conflicts, but I have just resolved it. Can it be merged? |
* [java] Process Selenium Manager output as JSON * [java] Use internal JSON parser instead of GSON --------- Co-authored-by: Diego Molina <[email protected]>
| SeleniumManagerJsonOutput jsonOutput = new Json().toType(output, | ||
| SeleniumManagerJsonOutput.class); | ||
| jsonOutput.logs.stream().filter(log -> log.level.equalsIgnoreCase(WARN)) | ||
| .forEach(log -> LOG.warning(log.message)); |
There was a problem hiding this comment.
@bonigarcia / @diemol can we log the debug information to LOG.FINE here? Is this the right place?
|
Seems we missed to update the Selenium Manager binary before merging this. |
4 participants
Description
This PR makes the Java bindings calls Selenium Manager using the flag
--output json(implemented in #11531). Then, the output is parsed using with GSON. From the parsed output, the logs messages from Selenium Manager withWARNlevel are displayed to the user (usingLOG.warningin Java).Motivation and Context
This PR is the Java implementation for #11365.
NOTE: To test this feature, the Selenium Manager binary (located in
common\manager) should be updated.Types of changes
Checklist