Allow timeout config to be set for local drivers#11545
Allow timeout config to be set for local drivers#11545krmahadevan wants to merge 1 commit intoSeleniumHQ:trunkfrom
Conversation
acae005 to
3595fb1
Compare
|
This creates both a new constructor and a new pattern for working with drivers. If we are going to add a new constructor, I'd prefer it be adding a |
|
Creating a new parameterized constructor for client config would perhaps also require me to accept all combos viz
I was trying to avoid this @titusfortner |
|
I think we can support only adding one new constructor with all 3 params. If someone needs to set this, they can also create default options and default service. |
3595fb1 to
efe16f1
Compare
@titusfortner - I have reverted the additional builder change |
|
This is conceptually doing the same #11532 is doing. I'd prefer we discuss an approach in these cases before starting to create PRs. Ideally, we can give feedback to the new contributor in #11532 and help them get their first commit in Selenium. In any case, I think this is the code we want to have so people can set timeouts for the local use case. |
|
Closing in favor of #11532 |
Fixes #11158
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist