Skip to content

Allow timeout config to be set for local drivers#11545

Closed
krmahadevan wants to merge 1 commit intoSeleniumHQ:trunkfrom
krmahadevan:fix_issue_11158
Closed

Allow timeout config to be set for local drivers#11545
krmahadevan wants to merge 1 commit intoSeleniumHQ:trunkfrom
krmahadevan:fix_issue_11158

Conversation

@krmahadevan
Copy link
Copy Markdown
Contributor

Fixes #11158

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@titusfortner
Copy link
Copy Markdown
Member

This creates both a new constructor and a new pattern for working with drivers. If we are going to add a new constructor, I'd prefer it be adding a ClientConfig parameter. Creating a builder for local drivers feels like a lot of extra maintenance and an extra choice for users without an obvious advantage. The primary reason I like RemoteWebDriverBuilder is that it tacks on augmentation for the user.

@krmahadevan
Copy link
Copy Markdown
Contributor Author

Creating a new parameterized constructor for client config would perhaps also require me to accept all combos viz

  • only client config
  • driver service and client config
  • options and client config
  • driver service and client config
  • all 3 params

I was trying to avoid this @titusfortner

@titusfortner
Copy link
Copy Markdown
Member

I think we can support only adding one new constructor with all 3 params. If someone needs to set this, they can also create default options and default service.

@krmahadevan
Copy link
Copy Markdown
Contributor Author

I think we can support only adding one new constructor with all 3 params. If someone needs to set this, they can also create default options and default service.

@titusfortner - I have reverted the additional builder change

@diemol
Copy link
Copy Markdown
Member

diemol commented Jan 15, 2023

This is conceptually doing the same #11532 is doing. I'd prefer we discuss an approach in these cases before starting to create PRs. Ideally, we can give feedback to the new contributor in #11532 and help them get their first commit in Selenium.

In any case, I think this is the code we want to have so people can set timeouts for the local use case.

@diemol
Copy link
Copy Markdown
Member

diemol commented Mar 21, 2023

Closing in favor of #11532

@diemol diemol closed this Mar 21, 2023
@krmahadevan krmahadevan deleted the fix_issue_11158 branch March 21, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Cannot set read timeout value in Local Drivers

3 participants