Conversation
p0deje
approved these changes
Jan 7, 2023
titusfortner
force-pushed
the
rb_driver_finder
branch
from
40b529d to
8e7efdd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Instead of the driver location happening in the Service class, this moves it to the local driver constructors using the new
DriverFinderclass. It moves all common local driver logic into a new module that gets included in each of the local drivers as a mixin.Motivation and Context
This is the equivalent of #11491 for Java and addresses the Ruby portion of #11372 & #11351
I'm marking this as draft as it is dependent on #11496 and #11352 and won't be ready until at least 4.9