[JS] [atoms] Use .textContent instead of .innerHTML in clear() action#11504
Merged
diemol merged 1 commit intoSeleniumHQ:trunkfrom Feb 15, 2023
Merged
[JS] [atoms] Use .textContent instead of .innerHTML in clear() action#11504diemol merged 1 commit intoSeleniumHQ:trunkfrom
diemol merged 1 commit intoSeleniumHQ:trunkfrom
Conversation
|
|
Member
|
@titusfortner @AutomatedTester do you know how we test the atoms? What is the process to tell the drivers to update them after merging this? |
Member
|
On the 02.02.23 TLC meeting it was decided to merge this and then ping ChromeDriver and GeckoDriver to update their atoms. |
diemol
force-pushed
the
tosmolka/11461
branch
from
5eb2418 to
577b624
Compare
diemol
approved these changes
Feb 15, 2023
This was referenced Mar 10, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes atom action clear() to use .textContent attribute instead of .innerHTML to clear the element. One exception is Firefox where it keeps current workaround.
Motivation and Context
This PR is related to issue #11461 . Atom action clear() fails on pages that require Trusted Types as it causes a Trusted Types Sink violation. This can be fixed by reimplementing the same behavior without calling into .innerHTML Trusted Types Sink.
Types of changes
Checklist