Skip to content

Remove unnecessary executable permission bit from several files#11502

Merged
diemol merged 1 commit intoSeleniumHQ:trunkfrom
jdufresne:exec-bit
Jan 2, 2023
Merged

Remove unnecessary executable permission bit from several files#11502
diemol merged 1 commit intoSeleniumHQ:trunkfrom
jdufresne:exec-bit

Conversation

@jdufresne
Copy link
Copy Markdown
Contributor

@jdufresne jdufresne commented Jan 1, 2023

Description

Some files had the executable permission bit set which are not executed by a user nor script directly.

Motivation and Context

Follow security and permission best practices by limiting executable permissions to only the files executed.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jan 1, 2023

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 1, 2023

Codecov Report

Base: 54.54% // Head: 54.54% // No change to project coverage 👍

Coverage data is based on head (6e6210c) compared to base (0b10e69).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #11502   +/-   ##
=======================================
  Coverage   54.54%   54.54%           
=======================================
  Files          85       85           
  Lines        5628     5628           
  Branches      243      243           
=======================================
  Hits         3070     3070           
  Misses       2315     2315           
  Partials      243      243           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jan 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Copy Markdown
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jdufresne!

@diemol diemol merged commit e43a6c2 into SeleniumHQ:trunk Jan 2, 2023
@jdufresne jdufresne deleted the exec-bit branch January 2, 2023 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants