Skip to content

[js][bidi] Add filtering capability to LogInspector#11495

Merged
harsha509 merged 2 commits intoSeleniumHQ:trunkfrom
pujagani:js-bidi-filter-log
Jan 2, 2023
Merged

[js][bidi] Add filtering capability to LogInspector#11495
harsha509 merged 2 commits intoSeleniumHQ:trunkfrom
pujagani:js-bidi-filter-log

Conversation

@pujagani
Copy link
Copy Markdown
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Add filtering capability to LogInspector

Motivation and Context

Allow users to filter logs based on log level

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@pujagani pujagani added C-nodejs JavaScript Bindings B-devtools Includes everything BiDi or Chrome DevTools related labels Dec 30, 2022
@pujagani pujagani requested a review from harsha509 January 2, 2023 05:24
@pujagani pujagani force-pushed the js-bidi-filter-log branch from 38e7a96 to 239a497 Compare January 2, 2023 11:33
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jan 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Copy Markdown
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @pujagani !

@harsha509 harsha509 merged commit 35906be into SeleniumHQ:trunk Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B-devtools Includes everything BiDi or Chrome DevTools related C-nodejs JavaScript Bindings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants