Skip to content

[java] Overload methods creating interactions to accept Point#11477

Merged
diemol merged 1 commit intoSeleniumHQ:trunkfrom
valfirst:overload-methods-creating-interactions-to-accept-point
Jan 3, 2023
Merged

[java] Overload methods creating interactions to accept Point#11477
diemol merged 1 commit intoSeleniumHQ:trunkfrom
valfirst:overload-methods-creating-interactions-to-accept-point

Conversation

@valfirst
Copy link
Copy Markdown
Contributor

@valfirst valfirst commented Dec 24, 2022 •
edited
Loading

Description

Add overloaded methods creating interactions to accept Point instead of (x, y) pair.

Motivation and Context

New methods are more convenient for users how work with point objects.
Invocations like

..., point.getX(), point.getY(), ...

can be replaced with simple

..., point, ...

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 24, 2022

Codecov Report

Base: 54.54% // Head: 54.54% // No change to project coverage 👍

Coverage data is based on head (6f79058) compared to base (de9a229).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##            trunk   #11477   +/-   ##
=======================================
  Coverage   54.54%   54.54%           
=======================================
  Files          85       85           
  Lines        5627     5627           
  Branches      243      243           
=======================================
  Hits         3069     3069           
  Misses       2315     2315           
  Partials      243      243

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pujagani
Copy link
Copy Markdown
Contributor

pujagani commented Dec 26, 2022

Implementation wise it seems fine. Though this adds an additional method, I am not sure it is consistent with other languages. @titusfortner I would like your thoughts here. Especially, I remember effort was put in to ensure all languages have a consistent API usage-wise. https://www.selenium.dev/documentation/webdriver/actions_api/wheel/

@pujagani pujagani added the C-java Java Bindings label Dec 26, 2022
@diemol diemol force-pushed the overload-methods-creating-interactions-to-accept-point branch from 6f79058 to 8b14294 Compare December 27, 2022 20:07
diemol
diemol approved these changes Dec 27, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine because the Java bindings already had this Point class implemented long before.

@diemol diemol force-pushed the overload-methods-creating-interactions-to-accept-point branch from 8b14294 to 4d5e5c3 Compare January 3, 2023 11:06
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jan 3, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@diemol diemol merged commit 811a8fe into SeleniumHQ:trunk Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diemol diemol diemol approved these changes

Assignees

No one assigned

Labels

C-java Java Bindings

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@valfirst @codecov-commenter @pujagani @diemol