Skip to content

[rust] Use LOCALAPPDATA env for Edge version detection in Windows#11455

Merged
bonigarcia merged 1 commit intotrunkfrom
se_mgr_edge_paths
Jan 9, 2023
Merged

[rust] Use LOCALAPPDATA env for Edge version detection in Windows#11455
bonigarcia merged 1 commit intotrunkfrom
se_mgr_edge_paths

Conversation

@bonigarcia
Copy link
Copy Markdown
Member

Description

This PR includes the use of the LOCALAPPDATA environment variable in Windows for the detection of Edge.

Motivation and Context

This logic was already implemented in Selenium Manager, but it has been lost in some former patch.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bonigarcia bonigarcia requested a review from diemol January 9, 2023 10:19
@bonigarcia bonigarcia merged commit 3930688 into trunk Jan 9, 2023
@bonigarcia bonigarcia deleted the se_mgr_edge_paths branch January 9, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants